potiuk commented on a change in pull request #19257:
URL: https://github.com/apache/airflow/pull/19257#discussion_r741866715
##########
File path: airflow/models/dag.py
##########
@@ -368,8 +369,11 @@ def __init__(
DeprecationWarning,
stacklevel=2,
)
-
- validate_key(dag_id)
+
+ if not is_ascii(dag_id):
+ # slugify dag id
+ dag_id = slugify(dag_id, lowercase=False)
Review comment:
Yeah. Same problem as with python_slugify. But I think the more
important question is - WHY we are limitng ourselves now. Is there any reason
(besides uf8mb4 causing too large index) why we are limited by the regexp
patterns we have? I think I might know why we should not use "." - because of
the subdags - but not about allowing only small set of ASCII characters?).
Does anyone know a good reason ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
