josh-fell opened a new pull request #19383:
URL: https://github.com/apache/airflow/pull/19383


   The `GoogleCampaignManagerDownloadReportOperator`, 
`GoogleDisplayVideo360DownloadReportOperator`, and 
`GoogleSearchAdsDownloadReportOperator` perform a string validation on the 
`bucket_name` arg in their constructor. This arg is a templated field which 
means the input could be an `XComArg`. This string validation fails when the 
input arg for `bucket_name` is an `XComArg` with `AttributeError: 'XComArg' 
object has no attribute 'startswith'`.
   
   This PR ensures that, if desired, the `bucket_name` arg can be successfully 
passed to these operators.
   
   Additionally included in this PR is some DRY refactoring of the operator 
unit tests to use some global variables across tests.
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to