[
https://issues.apache.org/jira/browse/AIRFLOW-4464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16833857#comment-16833857
]
ASF GitHub Bot commented on AIRFLOW-4464:
-----------------------------------------
jmcarp commented on pull request #5244: [AIRFLOW-4464] Add regression test for
case-insensitive ids in mysql.
URL: https://github.com/apache/airflow/pull/5244
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
By default, string comparisons in mysql are case-insensitive, so the task
ids "foo" and "FOO" are treated as identical. This means that a dag with those
task ids will fail to schedule with a sqlalchemy `IntegrityError` using mysql,
but not postgres or sqlite. This situation probably doesn't happen often, and
users probably shouldn't use task ids that are identical except for case, but I
think we should improve the behavior here. A few options:
Configure sqlalchemy to use a binary collation for string id columns under
mysql so that string comparisons are case-sensitive.
Require dag and task ids to be unique regardless of case. This would be a
breaking change.
Document that mysql users should configure mysql to use binary collations
for string types by default. This would still show users a 500 if the database
isn't configured correctly.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [ ] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix case-insensitive id columns in mysql
> ----------------------------------------
>
> Key: AIRFLOW-4464
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4464
> Project: Apache Airflow
> Issue Type: Improvement
> Reporter: Josh Carp
> Assignee: Josh Carp
> Priority: Minor
>
> By default, string comparisons in mysql are case-insensitive, so the task ids
> "foo" and "FOO" are treated as identical. This means that a dag with those
> task ids will fail to schedule with a sqlalchemy `IntegrityError` using
> mysql, but not postgres or sqlite. This situation probably doesn't happen
> often, and users probably shouldn't use task ids that are identical except
> for case, but I think we should improve the behavior here. A few options:
>
> * Configure sqlalchemy to use a binary collation for string id columns under
> mysql so that string comparisons are case-sensitive.
> * Require dag and task ids to be unique regardless of case. This would be a
> breaking change.
> * Document that mysql users should configure mysql to use binary collations
> for string types by default. This would still show users a 500 if the
> database isn't configured correctly.
>
> I'll submit a pull request with a failing unit test to describe the issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
