fenglu-g commented on a change in pull request #4064: AIRFLOW-3149 Support
dataproc cluster deletion on ERROR
URL: https://github.com/apache/airflow/pull/4064#discussion_r281813487
##########
File path: tests/contrib/operators/test_dataproc_operator.py
##########
@@ -507,10 +507,9 @@ def test_cluster_name_log_sub(self):
'cluster_name',
getattr(dataproc_task, 'cluster_name'), context)
setattr(dataproc_task, 'cluster_name', rendered)
- with self.assertRaises(TypeError):
- dataproc_task.execute(None)
- mock_info.assert_called_with('Deleting cluster: %s',
- u'smoke-cluster-testnodash')
+ dataproc_task.execute(None)
+ mock_info.assert_any_call('Deleting cluster: %s',
+ u'smoke-cluster-testnodash')
Review comment:
could you also add a test cast that checks that the error cluster is
deleted?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
