ashb commented on a change in pull request #19505:
URL: https://github.com/apache/airflow/pull/19505#discussion_r746729667
##########
File path: airflow/models/xcom.py
##########
@@ -97,7 +97,14 @@ def set(cls, key, value, task_id, dag_id,
execution_date=None, run_id=None, sess
execution_date = dag_run.execution_date
- value = XCom.serialize_value(value)
+ value = XCom.serialize_value(
+ value=value,
+ key=key,
+ task_id=task_id,
+ dag_id=dag_id,
+ execution_date=execution_date,
+ run_id=run_id,
+ )
Review comment:
Not sure -- haven't thought about it in detail.
Probably should be forced to use named args, (but not just a `**kwargs`
catch all).
We should bear AIP-42 in mind here too, which might add some form of
`mapping_index` argument.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
