ashb commented on pull request #19367:
URL: https://github.com/apache/airflow/pull/19367#issuecomment-966375995
> > Happy to discuss about if we still need the max_active_runs condition or
not too.
>
> I agree we no longer need it.
>
> I restricted the creation of dagruns on the UI and API too. Let me know if
I should remove these restrictions
If you want to reduce duplication, but keep the rollback you can go from
this:
```python
def test_dags_needing_dagruns_not_too_early(self):
...
session = settings.Session()
```
to this:
```python
def test_dags_needing_dagruns_not_too_early(self, session):
```
And remove the `session = settings.Session()`. That session pytest fixture
defined in `tests/conftest.py` already does the rollback.
But that should probably be a separate change to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
