dstandish commented on a change in pull request #19539:
URL: https://github.com/apache/airflow/pull/19539#discussion_r747711588
##########
File path: docs/apache-airflow/concepts/deferring.rst
##########
@@ -55,7 +55,7 @@ Writing Deferrable Operators
Writing a deferrable operator takes a bit more work. There are some main
points to consider:
-* Your Operator must defer itself based on a Trigger. If there is a Trigger in
core Airflow you can use, great; otherwise, you will have to write one.
Review comment:
I thought "based on" was a little less clear... based on in what sense?
Based on could imply that the deferral is in _response_ to a trigger, that
some how the trigger comes before the deferral. By using "with" instead, I
think it's slightly clearer that that you must include a trigger instance in
your deferral, i.e. as part of the deferral, i.e. within the deferral exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
