raphaelauv commented on a change in pull request #19324:
URL: https://github.com/apache/airflow/pull/19324#discussion_r748887411
##########
File path: airflow/providers/amazon/aws/secrets/secrets_manager.py
##########
@@ -253,3 +253,16 @@ def _get_secret(self, path_prefix, secret_id: str) ->
Optional[str]:
secret_id,
)
return None
+ except self.client.exceptions.AccessDeniedException as e:
+ self.log.debug(
+ "An error occurred (AccessDeniedException) when calling the "
+ "get_secret_value operation: %s",
+ str(e),
+ )
+ return None
+ except Exception as e:
Review comment:
Since all the calls to the secret backends are inside a try catch , it's
not necessary to add this last catch in your PR
see ->
https://github.com/apache/airflow/blob/9519bf664b1c20ebec940fc1c3daa097eca351b4/airflow/models/variable.py#L270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
