mik-laj commented on a change in pull request #19518:
URL: https://github.com/apache/airflow/pull/19518#discussion_r749111779



##########
File path: docs/apache-airflow-providers-google/connections/gcp.rst
##########
@@ -160,10 +160,13 @@ access token, which will allow to act on its behalf using 
its permissions. ``imp
 does not even need to have a generated key.
 
 .. warning::
-  
:class:`~airflow.providers.google.cloud.operators.kubernetes_engine.GKEStartPodOperator`,
   
:class:`~airflow.providers.google.cloud.operators.dataflow.DataflowCreateJavaJobOperator`
 and
   
:class:`~airflow.providers.google.cloud.operators.dataflow.DataflowCreatePythonJobOperator`
-  do not support direct impersonation as of now.
+  do not support direct impersonation as of now. Both are deprecated and new 
operators
+  
:class:`~airflow.providers.apache.beam.operators.beam.BeamRunJavaPipelineOperator`
 and

Review comment:
       
[GoogleBaseHook.provide_authorized_gcloud](https://github.com/apache/airflow/blob/6e43137cac4f9adedcb1622c7178862a051ecd30/airflow/providers/google/common/hooks/base_google.py#L484)
 is used to pass credentials from to Apache Beam process. And this method does 
not consider impersonation chain as each application have a different way to 
pass the impersonation chain
   
   I think this option was added by mistake in [this 
PR](https://github.com/apache/airflow/pull/12814/files) and has never been 
tested. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to