kazanzhy commented on a change in pull request #18431:
URL: https://github.com/apache/airflow/pull/18431#discussion_r751057294
##########
File path: airflow/sensors/sql.py
##########
@@ -58,39 +62,35 @@ class SqlSensor(BaseSensorOperator):
ui_color = '#7c7287'
def __init__(
- self, *, conn_id, sql, parameters=None, success=None, failure=None,
fail_on_empty=False, **kwargs
+ self,
+ *,
+ conn_id,
+ sql,
+ parameters=None,
+ success=None,
+ failure=None,
+ fail_on_empty=False,
+ hook_params=None,
Review comment:
I definitely agree with you.
But this inconsistency was provided by this PR
(https://github.com/apache/airflow/pull/18718), where BaseSqlOperator takes
`hook_params` and Connection takes `hook_kwargs`.
If this PR will be merged I'll create another one that resolves it.
Should I create an issue for that?
Resolve conflicting parameter SqlSensor(hook_params),
BaseSqlOperator(hook_params), Connection(_**hook_kwargs**_)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
