potiuk commented on issue #14396: URL: https://github.com/apache/airflow/issues/14396#issuecomment-971848723
Yep. It does look good. > Looks good to me in general. I think you can avoid a lot of the workarounds by keeping `get_template_context` on `TaskInstance` instead of making it a standalone function. That function always needs to be called with a TaskInstance anyway. I rather like the way @ferruzzi did it - look how many less imports the TaskInstance class has this way. For me ti really makes perfect sense to tie the "get_template_context" with Context in separate module and keep the imports there - they were only needed there to build "context fields" which are not actually used by TaskInstance. I like it much better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
