ferruzzi commented on issue #14396:
URL: https://github.com/apache/airflow/issues/14396#issuecomment-971902026


   @uranusjr - I do see what you are saying.  Passing `ti=self` to 
`get_context_template` [like 
that](https://github.com/ferruzzi/airflow/commit/4c86dbbab968a09386d09380a80650b5383bf5e4#diff-62f7d8a52fefdb8e05d4f040c6d3459b4a56fe46976c24f68843dbaeb5a98487R1307)
 feels a little off.  I went this route because it feels like a better logical 
fit in the Context module since it's essentially a Factory/Builder method.  The 
three modules are pretty heavily inter-related so I don't know if there is 
going to be a really pretty and clean solution, but I will keep trying to 
untangle it.
   
   I just wanted to get a temperature check before spending too much time 
running in the wrong direction.  It sounds like we're all comfortable with the 
direction so far.  As it stands right now, when I run the CI tests locally all 
import errors are clear, which is a good sign, but many/most/all of the WWW 
tests time out saying `failed on setup with "Failed: Timeout >60.0s"`.  So 
that's where I'm at with it at the moment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to