potiuk commented on a change in pull request #19662:
URL: https://github.com/apache/airflow/pull/19662#discussion_r751689583
##########
File path: airflow/models/baseoperator.py
##########
@@ -1000,7 +1000,7 @@ def post_execute(self, context: Any, result: Any = None):
if self._post_execute_hook is not None:
self._post_execute_hook(context, result)
- def on_kill(self) -> None:
Review comment:
One (easy but a bit tough) solution to that is that we do the same as in
"apply_defaults" case: Adding apache-airflow >=2.3.0 to all providers. But
this also means that we should not merge that change until **just before**
2.3.0 branch is cut off and coordinate relasing all providers to be compatible
with >= 2.3.0 **just** before 2.3.0 gets released.
This is possible option, but I am not sure if adding "on_kill" alone is
strong enough justrification for such a move.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
