chinwobble opened a new pull request #19668:
URL: https://github.com/apache/airflow/pull/19668


   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   Closes #18074
   
   The code was producing the error `TypeError: __init__() got multiple values 
for argument 'sdk_client'`.
   
   I created this small test to understand the problem.
   ```python
   from typing import Any, Dict, List, Optional, Sequence, Union
   
   class BaseHook:
       pass
   
   
   class AzureBaseHook(BaseHook):
       def __init__(self, sdk_client: Any, conn_id: str = 'azure_default'):
           print(sdk_client)
           self.sdk_client = sdk_client
           self.conn_id = conn_id
           super().__init__()
   
   class AzureContainerInstanceHook(AzureBaseHook):
       def __init__(self, *args, **kwargs):
           super().__init__(*args, **kwargs, sdk_client="Container Instances")
           # self.connection = self.get_conn()
   
   
   myhook = AzureContainerInstanceHook("abc")
   ```
   
   When the keyword is missing from `AzureContainerInstanceHook` the first 
positional argument is assumed to be `sdk_client`.
   When you change the code to `AzureContainerInstanceHook(conn_id="abc")`, 
this issue is fixed.
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to