uranusjr commented on a change in pull request #19700:
URL: https://github.com/apache/airflow/pull/19700#discussion_r752933036
##########
File path: airflow/config_templates/airflow_local_settings.py
##########
@@ -194,12 +194,13 @@
DEFAULT_LOGGING_CONFIG['handlers'].update(S3_REMOTE_HANDLERS)
elif REMOTE_BASE_LOG_FOLDER.startswith('cloudwatch://'):
+ url_parts = urlparse(REMOTE_BASE_LOG_FOLDER)
CLOUDWATCH_REMOTE_HANDLERS: Dict[str, Dict[str, str]] = {
'task': {
'class':
'airflow.providers.amazon.aws.log.cloudwatch_task_handler.CloudwatchTaskHandler',
'formatter': 'airflow',
'base_log_folder': str(os.path.expanduser(BASE_LOG_FOLDER)),
- 'log_group_arn': urlparse(REMOTE_BASE_LOG_FOLDER).netloc,
+ 'log_group_arn': ''.join(url_parts.netloc + url_parts.path),
Review comment:
```suggestion
'log_group_arn': url_parts.netloc + url_parts.path,
```
These are strings, `"".join()` is not meaningful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
