dbarrundiag commented on a change in pull request #19665:
URL: https://github.com/apache/airflow/pull/19665#discussion_r753566061
##########
File path: airflow/providers/amazon/aws/hooks/redshift.py
##########
@@ -138,6 +138,26 @@ def create_cluster_snapshot(self, snapshot_identifier:
str, cluster_identifier:
)
return response['Snapshot'] if response['Snapshot'] else None
+ def wait_for_state(self, cluster_identifier: str, target_state: str,
check_interval: float) -> None:
Review comment:
Thanks @o-nikolas! I was trying to follow the same pattern as the EC2
modules:
`airflow/providers/amazon/aws/hooks/ec2.py`
and
`airflow/providers/amazon/aws/operators/ec2_start_instance.py`
would you still prefer if i follow the eks example?
I kind of feel like I could develop the Sensor, but maybe leave the
`wait_for_state` in the Operator also? as a safe check? what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
