uranusjr commented on a change in pull request #19377:
URL: https://github.com/apache/airflow/pull/19377#discussion_r753922348
##########
File path: airflow/providers/facebook/ads/hooks/ads.py
##########
@@ -105,24 +110,74 @@ def bulk_facebook_report(
params: Dict[str, Any],
fields: List[str],
sleep_time: int = 5,
- ) -> List[AdsInsights]:
+ ) -> Union[List[AdsInsights], Dict[str, List[AdsInsights]]]:
"""
- Pulls data from the Facebook Ads API
+ Pulls data from the Facebook Ads API regarding Account ID with
matching return type.
+ The return type and value depends on the ``account_id`` configuration.
If the
+ configuration is a str representing a single Account ID, the return
value is the
+ list of reports for that ID. If the configuration is a list of str
representing
+ multiple Account IDs, the return value is a dict of Account IDs and
their
+ respective list of reports.
Review comment:
```suggestion
"""Pulls data from the Facebook Ads API regarding Account ID with
matching return type.
The return type and value depends on the ``account_id``
configuration. If the
configuration is a str representing a single Account ID, the return
value is the
list of reports for that ID. If the configuration is a list of str
representing
multiple Account IDs, the return value is a dict of Account IDs and
their
respective list of reports.
```
> Multi-line docstrings consist of a summary line just like a one-line
docstring, followed by a blank line, followed by a more elaborate description.
https://www.python.org/dev/peps/pep-0257/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
