mik-laj commented on a change in pull request #19737:
URL: https://github.com/apache/airflow/pull/19737#discussion_r754423362
##########
File path: scripts/ci/images/ci_run_docker_tests.sh
##########
@@ -0,0 +1,121 @@
+#!/usr/bin/env bash
Review comment:
My main concern is that this script imports file
`scripts/ci/libraries/_script_init.sh`, which initializes a lot of environment
variables. If I wanted to write this file in Python I would have to find a way
to access the following variables without using Bash: `BUILD_CACHE_DIR`,
`AIRFLOW_PIP_VERSION`, `WHEEL_VERSION`, `CONSTRAINTS_GITHUB_REPOSITORY`,
`DEFAULT_CONSTRAINTS_BRANCH`, `GITHUB_REGISTRY_PULL_IMAGE_TAG`. I agree that
duplicating code is not always the best idea, but generalizing this file and
file `ci_run_kubernetes_tests.sh` in Bash would make it very complicated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
