dimon222 commented on a change in pull request #19725:
URL: https://github.com/apache/airflow/pull/19725#discussion_r755411001
##########
File path: airflow/providers/postgres/hooks/postgres.py
##########
@@ -184,7 +184,8 @@ def get_iam_token(self, conn: Connection) -> Tuple[str,
str, int]:
# Pull the custer-identifier from the beginning of the Redshift URL
# ex. my-cluster.ccdre4hpd39h.us-east-1.redshift.amazonaws.com
returns my-cluster
cluster_identifier = conn.extra_dejson.get('cluster-identifier',
conn.host.split('.')[0])
- client = aws_hook.get_client_type('redshift')
+ session, endpoint_url = aws_hook._get_credentials()
+ client = session.client('redshift', endpoint_url=endpoint_url,
config=aws_hook.config, verify=aws_hook.verify)
Review comment:
Reread the code fragment - The above mentioned code piece is utilizing
hook for client_type 'rds', so I think i probably shouldn't be changing the
client_type it has in hook constructor, as it will break the non-Redshift
scenario in `else` condition (potentially).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
