josh-fell commented on a change in pull request #19497:
URL: https://github.com/apache/airflow/pull/19497#discussion_r755697566
##########
File path: airflow/utils/log/secrets_masker.py
##########
@@ -34,6 +34,7 @@
DEFAULT_SENSITIVE_FIELDS = frozenset(
{
'access_token',
+ 'access_key',
Review comment:
I'll close this PR and open an issue to bring in some discussion about
what a proper fix could/should be. (Unless you think updates related to any of
the above 2 questions would suffice.)
>I wonder if this is a "bug" in WASM connection, and it should be using
password for the secret key here?
Obviously some tradeoff between reusing a connection field vs making the
connection form more straightforward. Has there typically been deference in a
certain direction historically?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
