massamany commented on issue #19805: URL: https://github.com/apache/airflow/issues/19805#issuecomment-977875502
@potiuk Yes you're right, I didn't see that at first glance. Only the user/pwd is retrieved from connection and the rest of SMTP connection info is retrieved from config file. So it would be great to retrieve everything from the connection indeed. But (there's always a "but"), here is the information needed for the SMTP configuration : - smtp_host : OK to retrieve from connection - smtp_port : OK to retrieve from connection - smtp_starttls : **can't be retrieved from connection** - smtp_ssl = **can't be retrieved from connection** - smtp_user = : OK to retrieve from connection - smtp_password = : OK to retrieve from connection - smtp_mail_from = **can't be retrieved from connection** - smtp_retry_limit = **can't be retrieved from connection** So how to handle data that can't be retrieved from a connection ? Use the "extra" field ? If not, the SMTP configuration would still be split between connection and configuration and it would be useless, especially if one wants for example to declare 2 SMTP connections, one with SSL and the other one without SSL. In any case, I'm OK to take the PR. But you should know that I'm not an experienced Python dev (I come from the Java world). Still learning ;-) So I will certainly need help, especially for the testing part. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
