potiuk commented on a change in pull request #19809:
URL: https://github.com/apache/airflow/pull/19809#discussion_r756213310
##########
File path: tests/dag_processing/test_manager.py
##########
@@ -111,6 +113,7 @@ def waitable_handle(self):
class TestDagFileProcessorManager:
def setup_method(self):
+ dictConfig(DEFAULT_LOGGING_CONFIG)
Review comment:
I copied it from TestStandardTaskRunner - there it is much more obvious
why I used it this way. I have no super strong opinion, though I'd say in tests
stating expllicitly that "this test requires default config" is a bit more
resilient - for example if another test generates local_config and does not
remove it - using DEFULT_* will still work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
