[
https://issues.apache.org/jira/browse/AIRFLOW-4477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837139#comment-16837139
]
ASF GitHub Bot commented on AIRFLOW-4477:
-----------------------------------------
ryanyuan commented on pull request #5268: [AIRFLOW-4477] Add models methods to
BQHook
URL: https://github.com/apache/airflow/pull/5268
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following
[Airflow-4477](https://issues.apache.org/jira/browse/AIRFLOW-4477) issues and
references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
Add v2.models to BigQueryHook
Reference: https://cloud.google.com/bigquery/docs/reference/rest/v2/models
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
test_bigquery_hook.py:TestBigQueryHookModelOperations.test_bigquery_list_model
test_bigquery_hook.py:TestBigQueryHookModelOperations.test_bigquery_get_model
test_bigquery_hook.py:TestBigQueryHookModelOperations.test_bigquery_patch_model
test_bigquery_hook.py:TestBigQueryHookModelOperations.test_bigquery_delete_model
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [ ] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add v2.models to BigQueryHook
> -----------------------------
>
> Key: AIRFLOW-4477
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4477
> Project: Apache Airflow
> Issue Type: Improvement
> Reporter: Ryan Yuan
> Assignee: Ryan Yuan
> Priority: Major
>
> Add v2.models to BigQueryHook
> Reference: [https://cloud.google.com/bigquery/docs/reference/rest/v2/models]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
