uranusjr commented on a change in pull request #19806:
URL: https://github.com/apache/airflow/pull/19806#discussion_r756624818
##########
File path: airflow/providers/microsoft/psrp/hooks/psrp.py
##########
@@ -31,13 +33,19 @@ class PSRPHook(BaseHook):
Hook for PowerShell Remoting Protocol execution.
The hook must be used as a context manager.
+
+ :param psrp_conn_id: Required. The name of the PSRP connection.
+ :type psrp_conn_id: str
+ :param logging: If true (default), log command output and streams during
execution.
+ :type logging: bool
Review comment:
I wonder if we should instead make `poll_interval` configurable.
`logging` is not a great name IMO since it does not show the implication of the
process being polled, which I believe can be a performance impact. Allowing the
user to configure `poll_interval` can make this more visible, and
`poll_interval=None` (or `0` or `-1`?) would be a more natural value to disable
polling altoghether.
BTW, is logging still possible without polling? i.e. instead of outputting
eagerly, gather all outputs and log them after `end_invoke` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
