uranusjr commented on a change in pull request #19505:
URL: https://github.com/apache/airflow/pull/19505#discussion_r757082478
##########
File path: airflow/models/xcom.py
##########
@@ -364,6 +372,12 @@ def orm_deserialize_value(self) -> Any:
return BaseXCom.deserialize_value(self)
+def serialize_value_shim(**kwargs):
+ signature = inspect_function_arguments(XCom.serialize_value)
+ kwargs = {k: v for k, v in kwargs.items() if k in
signature.bound_arguments}
+ return XCom.serialize_value(**kwargs)
Review comment:
Being permissive is OK IMO, no need to complicate things too much for
things that would likely not going to work in the end anyway.
Putting the exaplaination in the implementation is much better than in tests
since it’s easy to find the implementation when you can’t understand a test,
but the other way around is much more difficult.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
