potiuk commented on a change in pull request #19505:
URL: https://github.com/apache/airflow/pull/19505#discussion_r757128435
##########
File path: airflow/models/xcom.py
##########
@@ -364,6 +372,12 @@ def orm_deserialize_value(self) -> Any:
return BaseXCom.deserialize_value(self)
+def serialize_value_shim(**kwargs):
+ signature = inspect_function_arguments(XCom.serialize_value)
+ kwargs = {k: v for k, v in kwargs.items() if k in
signature.bound_arguments}
+ return XCom.serialize_value(**kwargs)
Review comment:
I learned to provide all the "why's" and context in the commit messages
mostly for my future self, as I realized that I can't remember some of the
why's few months after I made a change. It saved me quite a number of times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]