fredthomsen commented on a change in pull request #18542:
URL: https://github.com/apache/airflow/pull/18542#discussion_r757217269
##########
File path: chart/templates/webserver/webserver-ingress.yaml
##########
@@ -39,12 +39,27 @@ metadata:
{{- toYaml . | nindent 4 }}
{{- end }}
spec:
- {{- if .Values.ingress.web.tls.enabled }}
+ {{- if and .Values.ingress.web.hosts (.Values.ingress.web.hosts | first |
kindIs "string" | not) }}
+ {{- $anyTlsHosts := false -}}
+ {{- range .Values.ingress.web.hosts }}
+ {{- if .tls.enabled }}
Review comment:
The change that is being made as part of this PR is moving hosts from an
array of strings ie list of hostnames, to an object containing host data:
hostname and tls config. I have assumed those are required here, but perhaps I
should change that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]