megan-parker commented on a change in pull request #19758:
URL: https://github.com/apache/airflow/pull/19758#discussion_r757667666



##########
File path: airflow/api_connexion/openapi/v1.yaml
##########
@@ -445,27 +428,22 @@ paths:
       summary: Update DAGs
       x-openapi-router-controller: airflow.api_connexion.endpoints.dag_endpoint
       operationId: patch_dags
-      tags: [DAG]
       parameters:
         - $ref: '#/components/parameters/PageLimit'
         - $ref: '#/components/parameters/PageOffset'
         - $ref: '#/components/parameters/FilterTags'
         - $ref: '#/components/parameters/UpdateMask'
-        - name: only_active
-          in: query
-          schema:
-            type: boolean
-            default: true
-          required: false
-          description: |
-            Only update active DAGs.
-        - name: dag_id_pattern
-          in: query
-          schema:
-            type: string
-          required: false
-          description: |
-            If set, only update DAGs with dag_ids matching this pattern.
+        - $ref: '#/components/parameters/OnlyActive'
+        - $ref: '#/components/parameters/DagIdPattern'
+      tags: [DAG]
+      requestBody:
+        required: true
+        content:
+          application/json:
+            schema:
+              $ref: '#/components/schemas/DAGCollection'

Review comment:
       @ephraimbuddy I made this change, but am wondering if you can clarify 
why the request body contains a DAG or DAGCollection schema? It doesn't seem 
like there is a DAG schema being passed in the request.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to