uranusjr commented on a change in pull request #19867:
URL: https://github.com/apache/airflow/pull/19867#discussion_r758233927



##########
File path: dev/Breeze/requirements.txt
##########
@@ -0,0 +1,4 @@
+click
+pytest
+pytest-xdist
+rich

Review comment:
       > One potential problem with it is that you have to actively "install" 
the latest version if you want new features and by having everything in the 
same repo
   
   I mentioned keeping the `Breeze` command small so this won’t be the case. 
The command will mostly just contain
   
   ```python
   def _find_airflow_repo_root():
       ...
   
   if __name__ == "__main__":
       import sys
   
       root = _find_airflow_repo_root()
       if root is None:
           # emit some sort of error message...
           sys.exit(1)
       sys.path.insert(0, root / "dev")
   
       import breeze
       breeze.run()
   ```
   
   and an upgrade is only needed if we need to change dependencies, which 
should be seldom (and when it happens you need to pip-install an in-tree 
Breeze’s requirements.txt anyway).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to