uranusjr commented on a change in pull request #19835:
URL: https://github.com/apache/airflow/pull/19835#discussion_r758582330
##########
File path: airflow/providers/databricks/hooks/databricks.py
##########
@@ -64,10 +66,12 @@
class RunState:
"""Utility class for the run state concept of Databricks runs."""
- def __init__(self, life_cycle_state: str, result_state: str,
state_message: str) -> None:
+ def __init__(
+ self, life_cycle_state: str, state_message: str, result_state: str =
'', *args, **kwargs
+ ) -> None:
Review comment:
Why flipping the arguments? This feels like a source for unnecessary
trouble. Also, why take `*args, **kwarg` and ignore them? This is usually an
anti-pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
