OmerJog commented on issue #5271: [AIRFLOW-4503] Support fully pig options URL: https://github.com/apache/airflow/pull/5271#issuecomment-491583940 @buom There is a failing test: ``` 3) FAIL: test_import_examples (tests.transplant_class.<locals>.C) ---------------------------------------------------------------------- Traceback (most recent call last): tests/core.py line 668 in test_import_examples self.assertEqual(len(self.dagbag.dags), NUM_EXAMPLE_DAGS) AssertionError: 19 != 18 -------------------- >> begin captured logging << -------------------- airflow.models.dagbag.DagBag: INFO: Filling up the DagBag from /dev/null --------------------- >> end captured logging << --------------------- ``` Since you are adding a new example dag (`example_pig_operator.py`) you probably need to change `NUM_EXAMPLE_DAGS = 18` to `19` in https://github.com/apache/airflow/blob/e76020c0a04a881f1b08ffd92809df41a1189e91/tests/core.py#L69 ------ @Fokko @feluelle quick question why the `NUM_EXAMPLE_DAGS `needs to be set manually? The test compare the number of dags in the dagbag to `NUM_EXAMPLE_DAGS`. Can `NUM_EXAMPLE_DAGS `be set by dynamically counting the number of files in the example folder instead of being manually defined ?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
