o-nikolas commented on a change in pull request #19665:
URL: https://github.com/apache/airflow/pull/19665#discussion_r760457905
##########
File path: airflow/providers/amazon/aws/hooks/redshift.py
##########
@@ -65,9 +81,9 @@ def cluster_status(self, cluster_identifier: str) -> str:
"""
try:
response =
self.get_conn().describe_clusters(ClusterIdentifier=cluster_identifier)['Clusters']
- return response[0]['ClusterStatus'] if response else None
+ return RedshiftClusterStates(response[0]['ClusterStatus']) if
response else None
Review comment:
Hey @dstandish,
Yes, you would need to correctly handle the case of an unknown/new status,
but there's no reason you can't correctly handle this as well as use Eunms
(E.g. coerce anything we haven't seen yet to an UNKOWN Enum state, or just
continue to return None like other errors cases can do in this existing code).
Certainly each approach has pros and cons, but I see no breaking reason if you
chose to use Enums.
Though I'm happy to disagree and commit to using strings if that's what
others think as well :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
