ashb commented on a change in pull request #19935:
URL: https://github.com/apache/airflow/pull/19935#discussion_r760996802
##########
File path: airflow/utils/process_utils.py
##########
@@ -55,7 +55,12 @@ def reap_process_group(
sig (SIGTERM) to the process group of pid. If any process is alive after
timeout
a SIGKILL will be send.
- :param pgid: process group id to kill
+ :param process_group_id: process group id to kill. This process group id
is retrieved earlier from
+ the process id of the process that started that process group. The
process that wants to
+ create the group should run `os.setpgid(0, 0)` as the first command
it executes which will
+ set group id = process_id. Effectively the process that is the
"root" of the group has
+ pid = gid and all other processes in the group have different pids
but the same gid (equal
+ the pid of the root process)
Review comment:
```suggestion
:param process_group_id: process group id to kill. This process group id
is retrieved earlier from
the process id of the process that started that process group.
The process that wants to
create the group should run `os.setpgid(0, 0)` as the first
command it executes which will
set group id = process_id. Effectively the process that is the
"root" of the group has
pid = gid and all other processes in the group have different
pids but the same gid (equal
the pid of the root process)
```
I'm also not quite sure what you mean by "This process group id is retrieved
earlier from the process id of the process that started that process group"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
