piotrkmita opened a new pull request #19984:
URL: https://github.com/apache/airflow/pull/19984


   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   Hello!
   
   We've started using that DruidOperator few weeks ago. We've realized that 
the DruidHook used there is [calling druid overlord every 1 
second](https://github.com/apache/airflow/blob/main/airflow/providers/apache/druid/hooks/druid.py#L104-L128)
 to get status, because it's using default timeout and it's not possible to set 
it in the operator itself. In our case ingestion takes around 1 hour, so there 
is no need to check it that often.
   
   Example log:
   
![image](https://user-images.githubusercontent.com/43473995/144471590-996ca185-3a24-421b-85a4-c57a2ca71142.png)
   
   We would would like to add timeout parameter to DruidOperator, so we can set 
how often DruidHook will be calling overlord to get status.
   
   Example log after change with timeout 180 seconds:
   
![image](https://user-images.githubusercontent.com/43473995/144472561-b01107d6-7e0c-4e46-b251-e14eb7bf4811.png)
   
   Please let me know if I've missed something.
   Thank you!
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to