uranusjr commented on pull request #19825:
URL: https://github.com/apache/airflow/pull/19825#issuecomment-985268177


   I’ve made all tests work and migrated most existing XCom usages to use 
`run_id`. One (very big) exception is operator link; since `get_link` is 
publicly subclassable, we can’t just change the argument. The current plan 
(after discussing with @ashb) is to add an optional flag on the class to toggle 
the behaviour, but there are much detail (and likely bikeshedding) around that, 
so I’m going to do it in a separate PR. The depracation warning implemented in 
this PR on passing `execution_date` to XCom is changed from DeprecationWarning 
to PendingDeprecationWarning to reflect that—we won’t commit the deprecation 
until we provide a migration path for operator links (which should still happen 
in 2.3, but let’s not jump the gun).
   
   I also want to extract typing changes I made here into a separate PR, and 
merge that first before I mark this PR as ready for review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to