potiuk commented on a change in pull request #20015:
URL: https://github.com/apache/airflow/pull/20015#discussion_r762044032
##########
File path: scripts/ci/kubernetes/ci_run_kubernetes_tests.sh
##########
@@ -93,7 +93,7 @@ function create_virtualenv() {
--constraint
"https://raw.githubusercontent.com/${CONSTRAINTS_GITHUB_REPOSITORY}/${DEFAULT_CONSTRAINTS_BRANCH}/constraints-${HOST_PYTHON_VERSION}.txt";
)
- if [[ -n ${GITHUB_REGISTRY_PULL_IMAGE_TAG=} ]]; then
+ if [[ ${CI:=} == "true" ]]; then
Review comment:
This should only happen on CI but onlywhen specific version is used to
avoid conflicts (PR has more information), Otherwise using constraints is
"safer".
This is BTW one Of the main reasons rewriting breeze to Python will help.
MacOS (Bash3) treatment of empty array as "undefined" is killing the whole
portability idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
