dstandish commented on a change in pull request #19572:
URL: https://github.com/apache/airflow/pull/19572#discussion_r762298113
##########
File path: airflow/providers/cncf/kubernetes/utils/pod_launcher.py
##########
@@ -51,10 +54,23 @@ def should_retry_start_pod(exception: Exception) -> bool:
class PodStatus:
"""Status of the PODs"""
- PENDING = 'pending'
- RUNNING = 'running'
- FAILED = 'failed'
- SUCCEEDED = 'succeeded'
+ PENDING = 'Pending'
+ RUNNING = 'Running'
+ FAILED = 'Failed'
+ SUCCEEDED = 'Succeeded'
+
+ terminal_states = {FAILED, SUCCEEDED}
Review comment:
is that because you think that someone might accidentally use the
deprecated enum with the current launcher?
do you know what purpose the deprecated launcher serves and when we can
remove it? i think @jedcunningham was thinking we do a major release for this
so we can flip the default behavior of "delete pod" to true. if so, would we
also take that opportunity to remove the deprecated pod launcher?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
