xinbinhuang commented on a change in pull request #19019:
URL: https://github.com/apache/airflow/pull/19019#discussion_r762383886
##########
File path: airflow/providers/jenkins/operators/jenkins_job_trigger.py
##########
@@ -130,15 +130,6 @@ def build_job(self, jenkins_server: Jenkins, params:
ParamType = "") -> Optional
:return: Dict containing the response body (key body)
and the headers coming along (headers)
"""
- # Since params can be either JSON string, dictionary, or list,
- # check type and pass to build_job_url
- if params and isinstance(params, str):
- params = ast.literal_eval(params)
Review comment:
Sounds good! Keep the compatibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
