ashb commented on a change in pull request #20011:
URL: https://github.com/apache/airflow/pull/20011#discussion_r763000313
##########
File path: airflow/models/skipmixin.py
##########
@@ -66,9 +67,10 @@ def _set_state_to_skipped(self, dag_run: "DagRun", tasks:
"Iterable[BaseOperator
def skip(
self,
dag_run: "DagRun",
- execution_date: "timezone.DateTime",
- tasks: "Iterable[BaseOperator]",
- session: "Session" = None,
+ execution_date: "DateTime",
+ tasks: Sequence["BaseOperator"],
+ *,
+ session: "Session",
Review comment:
We probably shouldn't make session a kw-only arg, as that _might_ break
someone's custom operator :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
