dstandish commented on a change in pull request #19726:
URL: https://github.com/apache/airflow/pull/19726#discussion_r763462578
##########
File path:
airflow/providers/cncf/kubernetes/backcompat/backwards_compat_converters.py
##########
@@ -21,18 +21,16 @@
from kubernetes.client import ApiClient, models as k8s
from airflow.exceptions import AirflowException
-from airflow.providers.cncf.kubernetes.backcompat.pod import Port, Resources
-from airflow.providers.cncf.kubernetes.backcompat.pod_runtime_info_env import
PodRuntimeInfoEnv
-def _convert_kube_model_object(obj, old_class, new_class):
+def _convert_kube_model_object(obj, old_class_name, new_class):
Review comment:
Your comment reminds me that by the time we get to this bit of code
(e.g. if an airflow backcompat class is used) then the user will _already_
have imported the backcompat module, and the warning presumably would have
already been emitted. So no need, I suppose, to add another warning here as I
have suggested in option 1.
That said I would still just get rid of the `old_class_name` param since it
isn't doing anything useful. We can just say we expected class `new_class` or
the equivalent airflow backcompat class..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
