mik-laj opened a new pull request #20095: URL: https://github.com/apache/airflow/pull/20095
The tests did not follow the best test writing practices used in the project: * Instead of mocking, class inheritance was used to override method implementations * No environment variables were used to mock the connection, making the code overly complex and less consistent. See: https://airflow.apache.org/docs/apache-airflow/stable/best-practices.html#mocking-variables-and-connections * Instead of fixtures, the required dependencies were created in the setup method, which made dependency tracking difficult. * The tests were duplicated, but for no good reason. Part of: https://github.com/apache/airflow/issues/19797 <!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information. In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
