uranusjr commented on a change in pull request #19931:
URL: https://github.com/apache/airflow/pull/19931#discussion_r763821844
##########
File path: airflow/api/client/local_client.py
##########
@@ -36,18 +38,20 @@ def delete_dag(self, dag_id):
return f"Removed {count} record(s)"
def get_pool(self, name):
- the_pool = pool.get_pool(name=name)
+ the_pool = Pool.get_pool(pool_name=name)
+ if not the_pool:
+ raise PoolNotFound(f"Pool {name} not found")
Review comment:
Looking at where this function is being called, I wonder if we should
just get rid of this exception altogether and just return `Optional`. Not sure
about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
