ashb commented on a change in pull request #19758:
URL: https://github.com/apache/airflow/pull/19758#discussion_r763891512
##########
File path: airflow/api_connexion/openapi/v1.yaml
##########
@@ -412,25 +412,38 @@ paths:
- $ref: '#/components/parameters/PageOffset'
- $ref: '#/components/parameters/OrderBy'
- $ref: '#/components/parameters/FilterTags'
- - name: only_active
- in: query
- schema:
- type: boolean
- default: true
- required: false
- description: |
- Only return active DAGs.
-
- *New in version 2.1.1*
- - name: dag_id_pattern
- in: query
- schema:
- type: string
- required: false
- description: |
- If set, only return DAGs with dag_ids matching this pattern.
+ - $ref: '#/components/parameters/OnlyActive'
+ - $ref: '#/components/parameters/DagIdPattern'
+ responses:
+ '200':
+ description: Success.
+ content:
+ application/json:
+ schema:
+ $ref: '#/components/schemas/DAGCollection'
+ '401':
+ $ref: '#/components/responses/Unauthenticated'
- *New in version 2.3.0*
+ patch:
+ summary: Update DAGs
+ x-openapi-router-controller: airflow.api_connexion.endpoints.dag_endpoint
+ operationId: patch_dags
+ parameters:
+ - $ref: '#/components/parameters/PageLimit'
+ - $ref: '#/components/parameters/PageOffset'
+ - $ref: '#/components/parameters/FilterTags'
+ - $ref: '#/components/parameters/UpdateMask'
+ - $ref: '#/components/parameters/OnlyActive'
+ - $ref: '#/components/parameters/DagIdPattern'
Review comment:
This endpoint by default operates on _all_ DAGS by default right? That
feels like a bit of a foot gun, and I _think_ I'd like to make dag id pattern
required here, i.e. `?dag_id_pattern=%` is required to operate on all dags.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
