uranusjr commented on a change in pull request #20104:
URL: https://github.com/apache/airflow/pull/20104#discussion_r763974125
##########
File path: airflow/settings.py
##########
@@ -77,7 +80,7 @@
DAGS_FOLDER: str = os.path.expanduser(conf.get('core', 'DAGS_FOLDER'))
engine: Optional[Engine] = None
-Session: Optional[SASession] = None
+Session: Callable[..., SASession]
Review comment:
Hmm no, SQLAlchemy is not type hinted well enough, annotating this as
`sessionmaker` would make `Session()` return `Any`. I’ll keep this for now
since this is more useful in general.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
