josh-fell commented on issue #19883: URL: https://github.com/apache/airflow/issues/19883#issuecomment-987971464
> @josh-fell why don't we have the same problem with Security Token field in Salesforce connection? For two reasons: 1. The string "token" is already included in `DEFAULT_SENSITIVE_FIELDS` in the [secrets masker](https://github.com/josh-fell/airflow/blob/26e3c7f374f6c2c4eaaedb5aa72a5d53b8843258/airflow/utils/log/secrets_masker.py#L34-L49) logic. Any extra with that string in its key would be masked. 2. The [logging line](https://github.com/apache/airflow/blob/387893ae1820ca1553d05146ad9d2baaa0c0a519/airflow/hooks/base.py#L69-L80) that is creating this issue is _only_ written when `host` is provided in a connection. This brings me to the "intriguing" part: Why is this only logged when `host` is provided? And is it necessary to log all of the details of the connection rather than just what connection ID is used? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
