uranusjr commented on pull request #20114:
URL: https://github.com/apache/airflow/pull/20114#issuecomment-988532609


   One downside to this change is it requires `sudo` to exist (it is not 
guaranteed), which is unnecessary if the Airflow’s runtime user _does_ have 
permission to chown. Maybe it’s a better idea to use `pwm` first, and fall back 
to `sudo` only on PermissionError? It should also be worthwhile to catch 
`FileNotFoundError` from the subprocess call (which would mean `sudo` does not 
exist) and emit a more friendly error (or just carry on silently).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to