uranusjr commented on a change in pull request #20096:
URL: https://github.com/apache/airflow/pull/20096#discussion_r764589818
##########
File path: airflow/www/views.py
##########
@@ -543,7 +543,7 @@ class AirflowBaseView(BaseView):
}
if not conf.getboolean('core', 'unit_test_mode'):
- extra_args['sqlite_warning'] = settings.Session.bind.dialect.name ==
'sqlite'
+ extra_args['sqlite_warning'] = settings.engine.bind.dialect.name ==
'sqlite'
Review comment:
```suggestion
extra_args['sqlite_warning'] = settings.engine.dialect.name ==
'sqlite'
```
I think Mypy will complain None does not have attribute dialect though.
Consider the protocol approach, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
