ashb commented on issue #12611:
URL: https://github.com/apache/airflow/issues/12611#issuecomment-988669715


   > * Will we leverage a 3rd party library e.g. apprise?
   > * How will it be part of providers packages
   
   Both of these have the same answer -- yes part of providers, so it doesn't 
need a "core" decision. So we could have an apache-airflow-providers-apprise 
that provides a load of notifications, and/or we could have a notification in 
apache-airflow-providers-slack too.
   
   > What will the notification abstraction in code look like?
   
   It could be as simple as this:
   
   ```python
   class Notifier(Protocol):
       def __call__(self, **context): -> None
   ```
   
   i.e. a function that gets called with the TI context.
   
   > * Will notifications be registered in the metastore?
   
   The notifications for a TI: they will exist in the serialized_dag table, but 
I don't think a "notifications" table or anything like that.
   All the possible notification classes: no, not in the metastore.
   
   > * Will there be any UI changes to view sent notification 
configuration/sent notifications?
   
   Configuration should use existing Connections mechanism, so no on that front.
   Sent notifications: possibly, but that isn't needed in the first version I 
don't think. At least not in a general case. (I can see that being useful if we 
have a HTTP Webhook notification to debug issues, much like how GitHub has for 
apps - you can see recent deliveries and the responses etc.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to