potiuk edited a comment on pull request #20066: URL: https://github.com/apache/airflow/pull/20066#issuecomment-988764211
Looks cool! > I have created a new hook for generating the autocompletion script `Generate autocompletion command script for Breeze2` This script fails as files are modified in this hook. It is supposed to modify the files by generating the script. How could I avoid this error? That's expected :). the script will fail when the files are generated and you are supposed to add them to the commit at this point.. Next time when generation will produce the very same files (providing that next time it will be exactly the same file really - sometimes there is generation date or things like that which makes the file slighlty different). Then - it will not fail, because the generated files will not be modified (they will be overwritten but if the content is the same, the will be "the same files"). > Also, I get an error in one more hook `Add license for all shell files`. As the above hook is modifying the shell files, this script also fails Exclude the directory with scripts from Licence check (this is another pre-commit that does it). License headers are not required for files that were automatically generated, so we can exclude the whole dir. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
