ashb commented on a change in pull request #20147:
URL: https://github.com/apache/airflow/pull/20147#discussion_r765073633



##########
File path: airflow/task/task_runner/base_task_runner.py
##########
@@ -57,7 +57,8 @@ def __init__(self, local_task_job):
             except AirflowConfigException:
                 self.run_as_user = None
 
-        self._error_file = NamedTemporaryFile(delete=True)
+        self._error_file = NamedTemporaryFile(delete=False)

Review comment:
       Lets do something like this
   ```suggestion
           impersonation = self.run_as_user and (self.run_as_user != getuser())
           self._error_file = NamedTemporaryFile(delete=not impersonation)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to